Open
Conversation
This apparently broke on flyctl 0.3.210, probably went unnoticed since it's not a frequently used feature; user who reported it was stuck on 0.3.208. The 30-day session timeout feature has had a bumpy history: 1. 1f90b74 — "Introducing 30-day cli session timeout" (#4630, Nov 5 2025) — the original version had no bypass at all, meaning even env var tokens would hit the timeout. 2. 80affc2 — "Revert session timeout feature" (#4633) — reverted due to issues. 3. 5a396de — "session timeout-improved" (#4645, Nov 10 2025) — reintroduced with an env var bypass for CI/CD, but missed the -t flag. This is the commit that introduced the bug the reporting user hit. So the -t flag was never accounted for — it was an oversight in the improved version (#4645) when the env var bypass was added. This code applies the env var timeout bypass for a token passed via -t as well.
dangra
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This apparently broke on flyctl 0.3.210, probably went unnoticed since it's not a frequently used feature; user who reported it was stuck on 0.3.208.
With a freshly-generated token passed via -t:
The 30-day session timeout feature has had a bumpy history:
So the -t flag was never accounted for — it was an oversight in the improved version (#4645)
when the env var bypass was added.
This code applies the env var timeout bypass for a token passed via -t as well.