Substitute image_config "." with build image during deploy#4772
Open
rustyconover wants to merge 1 commit intosuperfly:masterfrom
Open
Substitute image_config "." with build image during deploy#4772rustyconover wants to merge 1 commit intosuperfly:masterfrom
rustyconover wants to merge 1 commit intosuperfly:masterfrom
Conversation
When deploying multi-container apps, files with `image_config` set to "." are now substituted with the build image, matching the existing convention where `container.Image = "."` is replaced. This applies to both top-level machine config files and per-container files. Without this change, there was no way to reference the just-built image in a file's `image_config` field — users had to hardcode the full image reference, which defeats the purpose of dynamic deploys. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateContainerImage()to substituteimage_configreferences of"."with the build image, for both top-levelMachineConfig.Filesand per-containerContainerConfig.Filescontainer.Image = "."is replaced with the build image during deployimage_configFixes #4771
Test plan
go test ./internal/command/deploy/ -run TestLaunchInputForUpdate)🤖 Generated with Claude Code