fix(certs): respect --json output in certs setup#4775
Open
manasa-bhagwat wants to merge 1 commit intosuperfly:masterfrom
Open
fix(certs): respect --json output in certs setup#4775manasa-bhagwat wants to merge 1 commit intosuperfly:masterfrom
manasa-bhagwat wants to merge 1 commit intosuperfly:masterfrom
Conversation
Signed-off-by: manasa <manasa.bhagwat.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
fly certs setupignoring--jsonoutput mode.runCertificatesSetupininternal/command/certificates/root.go--jsonis set, return API response viarender.JSON(...)and skip human-readable DNS instructionsFixes #4724.
Why
fly certs setup --jsonshould be machine-readable for automation/IaC workflows.Before this change, the command always printed human-oriented setup text, which broke JSON-driven scripting.
Test plan
go build -o .\bin\flyctl.exe ..\bin\flyctl.exe certs setup <hostname> --json -a <app>DNS Setup Optionshuman text).\bin\flyctl.exe certs setup <hostname> -a <app>Notes
certs setup).