fix consumer destroy#141
Open
chandr-andr wants to merge 1 commit intosuperstreamlabs:masterfrom
Open
Conversation
chandr-andr
changed the title
Contributor
|
Hi @chandr-andr thanks for the fixes, we will test it ASAP and keep you updated |
Author
|
@idanasulinmemphis Thank you) |
| real_name = consumer_name.lower() | ||
| if generate_random_suffix: | ||
| consumer_name = self.__generateRandomSuffix(consumer_name) | ||
| real_name += "_" + consumer_name.split("_")[-1] |
Contributor
There was a problem hiding this comment.
This change is wrong since real name is the consumer name without the suffix which is the desired behavior
Author
There was a problem hiding this comment.
Okay, but it breaks consumer shutdown, I'll find another way to fix it soon.
Contributor
There was a problem hiding this comment.
Great, thanks, waiting for that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for your awesome project!
I found two problems with the consumer shutdown.
Firstly, there is an error if you want to destroy consumer, but you decided to use the method
fetchinstead ofconsume:It occurs because this variable will be set only if the client-side application calls
consume.Secondly, if you are using the
generate_random_suffixparameter for consumer constructorawait memphis.consumer(generate_random_suffix=True, ...)memphis add a key with name without suffix in consumer name -self.consumers_map[map_key] = consumer,map_keyhere is default name without suffix, so, when consumer tries to destroy an error occurs:Error is Implicit but I found that error was raised here: