Skip to content

add light pull request template#1012

Merged
manuel3108 merged 4 commits intomainfrom
pr-template
Mar 28, 2026
Merged

add light pull request template#1012
manuel3108 merged 4 commits intomainfrom
pr-template

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Mar 28, 2026

Closes nothing!

Description

Adding a light PR description to help new contributors

Checklist

  • Updated snapshots if applicable
  • Added a changeset if applicable
  • Allowed maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 28, 2026

⚠️ No Changeset found

Latest commit: 721a6fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 28, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@1012
npx https://pkg.pr.new/sv@1012
npx https://pkg.pr.new/@sveltejs/sv-utils@1012

commit: 721a6fb

@sacrosanctic
Copy link
Copy Markdown
Contributor

Should be in present tense.

Comment on lines +9 to +12
- [ ] Updated [snapshots](../CONTRIBUTING.md#update-snapshots) _if applicable_
- [ ] Added a [changeset](../CONTRIBUTING.md#generating-changelogs) _if applicable_
- [ ] Allowed maintainers to edit this PR
- [ ] I care about what I'm doing, no matter the tool I use _(Notepad, Sublime, VSCode, AI...)_
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this like a "I'm not a robot" button?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit yes. but in the end, I think that we (I) don't really care it's it's AI. I care more that you care ^^

manuel3108
manuel3108 previously approved these changes Mar 28, 2026
Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally i would avoid adding checkboxes to the template. I know that everyone does it, but that github is automatically counting the tasks and displaying them everywhere makes this kinda nonsense for me.

I do agree that we should have a template and I even more agree with the contents.

I have seen other projects that have put the PR instructions in an HTML comment, so that they are still available while creating the PR but basically don't harm anyone once the PR has been created.

Again, given my low activity around here I don't want to be a blocker for anyone or anything here. Just my two cents.

@manuel3108 manuel3108 dismissed their stale review March 28, 2026 14:11

misclick

@sacrosanctic
Copy link
Copy Markdown
Contributor

Maybe we just need better bots. No one reads (I'm also guilty of this). If they did, they would've read CONTRIBUTING.md.

jycouet and others added 2 commits March 28, 2026 16:27
Co-authored-by: Scott Wu <sw@scottwu.ca>
@manuel3108 manuel3108 merged commit c0aed8b into main Mar 28, 2026
8 checks passed
@manuel3108 manuel3108 deleted the pr-template branch March 28, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants