fix(findsources): handle repos with many tags#217
Open
16Martin wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
This is v2. The initially proposed version is already so large, it didn't make much sense anymore. This version is now now a more local implementation of |
* rewrite of the block that tries to guess tag prefixes instead of iterating over pages * introduce different gen_new_prefixes to keep fix local
Collaborator
|
I fixed typos and flake8 issues. @16Martin Please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #206
The root cause are our current approaches for generating GitHub web and API calls. This patch does not attempt to fix this.
The ultimate current breaking point is the code block between the lines 263 and 287. It had/-s many issues which unfortunately cancel each other out just enough to appear reasonably stable. (#205 (comment))
In its current state, this code block's effectiveness is enhanced by its bugs. Resolving the bugs lowers the effectiveness and brings back the original performance problems. Until a sufficient amount of fixes are in place, all conceivable fixes essentially substitute one reason for timeout issues with another reason for timeout issues. Improvement vs regression is a function over API limits, network throughput and input dataset.
I therefore propose this bigger change which unfortunately bleeds into
comparable_version.py.It filters out more error messages, handles API results better and handles large scale repos better.