Diagnose public protocol requirements witnessed by internal protocol extensions #85846
Conversation
|
There is still work to be done here (since a draft PR). This change breaks 18 tests, most of them due to the warning that is generated. One approach is to introduce a new UPCOMING_FEATURE flag and hide the diagnose behind it. |
|
These fail due to the warning: These fail due to the error: |
lib/Sema/TypeCheckProtocol.cpp
Outdated
| if (!witness->isAccessibleFrom(actualScopeToCheck.getDeclContext())) { | ||
| if (dc->getParentModule()->isResilient()) { | ||
| // This module was built with -enable-library-evolution | ||
| dc->getASTContext().Diags.diagnose(witness->getLoc(), diag::err_private_member_witness_public_protocol, |
| return 42 | ||
| } | ||
| } | ||
|
|
| protocol InternalProtocol: PublicProtocol {} | ||
|
|
||
| extension InternalProtocol { | ||
|
|
| ERROR(err_private_member_witness_public_protocol,none, | ||
| "%0 is private and should not witness public protocol %1", | ||
| (const ValueDecl *,const ProtocolDecl *)) | ||
| WARNING(warn_private_member_witness_public_protocol,none, |
There was a problem hiding this comment.
There's already a mechanism to emit something as a warning or error, with warnUntilFutureSwiftVersionIf()
sepy97
force-pushed
the
public-decl-internal-protocol
branch
2 times, most recently
from
8d1eebe to
48c1267
Compare
Private member witnessing a public constraint should be deprecated. If StrictSemaForTextualInterface is set, compiler emits a warning (in future versions -- an error) when access check is not passed. rdar://74904373
sepy97
force-pushed
the
public-decl-internal-protocol
branch
from
48c1267 to
3340009
Compare
2 participants
Private member witnessing a public constraint should be deprecated. With this change compiler emits an error when access check is not passed in library evolution mode (emits a warning otherwise).
rdar://74904373