Skip to content

Add a FIXME to CopyPropagation to highlight an incomplete fix. #85870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atrick wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a FIXME to CopyPropagation to highlight an incomplete fix. #85870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/SILOptimizer/Utils/OSSACanonicalizeOwned.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,17 @@ bool OSSACanonicalizeOwned::computeCanonicalLiveness() {

// Conservatively treat a conversion to an unowned value as a pointer
// escape. Is it legal to canonicalize ForwardingUnowned?
//
// FIXME: BitwiseEscape is defined as a leaf use for liveness purposes. It
// implies that any use of those bits that require liveness are already
// handled by something like mark_dependence or fix_lifetime. It should
// be treated as an InstantaneousUse here not a PointerEscape. This was a
// workaround for invalid SIL which may still miscompile in other passes.
// Valid fixes are:
// 1. Compile the stdlib with lexical lifetimes.
// 2. Fix the source to correctly extendLifetime when bit-casting.
// 3. Conservatively change operand ownership for the SIL instruction to
// PointerEscape.
case OperandOwnership::ForwardingUnowned:
case OperandOwnership::PointerEscape:
case OperandOwnership::BitwiseEscape:
Expand Down