1021310: Need to create style and appearance section for Pager component#8169
Open
BarathAravindKannan wants to merge 2 commits intohotfix/hotfix-v33.1.44from
Open
1021310: Need to create style and appearance section for Pager component#8169BarathAravindKannan wants to merge 2 commits intohotfix/hotfix-v33.1.44from
BarathAravindKannan wants to merge 2 commits intohotfix/hotfix-v33.1.44from
Conversation
…ent in documentation
Contributor
|
Build Status: INPROGRESS 🔃 |
Contributor
|
CI Status: SUCCESS ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task 1021310: Need to create style and appearance section for Pager component in documentation
Code Studio usage(Mandatory)
Code Studio used in this PR/MR?
If
Yes: Primary use (choose one)Outcome
If “Cost time” explain in short (1 or 2 lines):
Log Details
Component: Blazor Pager (Pager component docs)
Feature: Style-and-appearance documentation and CSS guidance for Pager (page numbers, nav buttons, page-size dropdown, focus/disabled states)
Files Modified:style-and-appearance.md
blazor/pager/style-and-appearance/numeric-items.md
blazor/pager/style-and-appearance/navigation-buttons.md
input-fields.md
blazor/pager/style-and-appearance/focus-states.md
ISSUE:Initial CSS suggestions used selectors not present in the runtime DOM (e.g., .e-navigation was not present).
Incorrect disabled selector recommended (.e-disabled vs actual .e-disable used in DOM).
Dropdown renders outside .e-pager; initial examples targeted .e-pager .e-dropdownlist instead of the dropdown component’s list container.
Multiple documentation files were generated, but the user preferred and ultimately used the consolidated style-and-appearance.md.
User manually tested local styles, produced a working snippet, and resubmitted it to correct the docs.
ROOT CAUSE:Incorrect assumptions about the component’s rendered class names and structure; the pager’s dropdown and some button classes render under different DOM containers and selectors.
Over-generalized examples copied from similar components (DataGrid) without verifying Pager-specific markup.
Documentation generation produced multiple granular files before validating which file(s) would be used in practice.
CHANGES MADE:style-and-appearance.md — Dropdown section: Replaced dropdown selectors with correct usage for input focus and dropdown list items (use .e-input-focus and .e-dropdownbase .e-list-item...) and added an explanatory note about dropdown rendering outside .e-pager.
input-fields.md — Dropdown examples: Updated input field and list-item CSS to use .e-input-focus and .e-dropdownbase selectors; added examples that match the user-tested snippet and focus/hover states.
blazor/pager/style-and-appearance/numeric-items.md: Created comprehensive numeric item styling guidance (hover, active, sizing, shadows).
blazor/pager/style-and-appearance/navigation-buttons.md: Created navigation button styling guidance and corrected disabled-state semantics.
blazor/pager/style-and-appearance/focus-states.md: Created focus/interaction accessibility guidance and transition examples.
RESULT:Pager style docs reflect DOM-accurate selectors: dropdown input focus via .e-input-focus, dropdown list items via .e-dropdownbase .e-list-item..., active/current item underline, and corrected disabled-state guidance.
User-provided tested snippet was incorporated into the main dropdown documentation and input-fields.md, ensuring examples match local behavior.
A complete style-and-appearance folder with targeted guidance is available, and style-and-appearance.md now contains the consolidated, actionable instructions the user preferred.
TESTING / VERIFICATION:Apply the updated CSS in the consuming Blazor app (site stylesheet or theme bundle) and confirm:Page-size dropdown input shows focus style when opened (inspect element has .e-input-focus applied).
Dropdown options render under .e-dropdownbase and show the specified background-color/color for .e-list-item.e-item-focus / .e-list-item.e-active.
Navigation buttons show disabled appearance matching .e-disable (confirm actual runtime class and update if needed).
Active/current page shows the intended border-bottom and color (inspect element for .e-currentitem).
Suggested quick verification steps:Start Blazor app and open a page with SfPager.
Open browser DevTools and inspect Pager DOM for the selectors above.
Paste the CSS snippets from style-and-appearance.md into DevTools to validate visual effect before committing.
NOTES / FOLLOW-UPS:Recommendation: consolidate to style-and-appearance.md as primary source and keep the other files as optional deep-dives or archive them to reduce confusion.
Suggest scanning the running app to validate all actual class names (.e-disable vs .e-disabled, any localized variations) and update docs if additional deviations are found.
Offer to remove or merge extra files, or to update the Pager samples to explicitly show markup (via DevTools snapshots) so future docs are DOM-accurate.
Add a short troubleshooting note in the main doc explaining that dropdowns render outside .e-pager and showing how to find correct selectors via DevTools.
Type of Change
Reviewer Checklist (Mandatory)