fix: Allow 'none' line color for shape features#94
Merged
ThomasHalwax merged 6 commits intomainfrom Feb 15, 2026
Merged
Conversation
…and rotation - Place text on map as Point geometry with simple markdown rendering (# headings, ## subheadings, - bullet lists, plain text) - Text rendered to canvas, displayed as OL Icon style - Zoom-dependent scaling: text appears full size at creation zoom level, shrinks when zoomed out, minimum 15% size - Properties panel: text input, text/background color, opacity, font size, rotation slider, 'Use current view as full size' button - Sidebar tags: SHAPE + TEXT/LINE/POLYGON for all shape types - Guard in _bbox.js for canvas icons without explicit dimensions - getMapResolution() exposed as service for property panels
- Shapes dropdown menu showing Line, Polygon, and Text tools - Text shape with markdown rendering (headings, bullet lists) - Both showing the properties panel with style options
feat: Add text shapes with markdown support
When selecting the empty/none swatch in the line color palette, shapes now correctly render without a stroke. Previously, the fallback to '#000000' made it impossible to remove the border. - shape.js: Only render stroke when line-color is explicitly set - ShapeProperties.js: Persist null instead of undefined for 'none' and correctly detect the 'none' state in the UI
The styleRegistry merges defaults (including line-color: #000000) with the style props from shape.js. When 'fill only, no stroke' was selected, the style object omitted line-color entirely, causing the registry default black stroke to bleed through. Now explicitly sets line-color: transparent and line-width: 0 to suppress the registry default stroke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selecting the empty/none swatch in the line color palette, shapes now correctly render without a stroke. Previously, the fallback to
#000000made it impossible to remove the polygon border.Changes:
line-coloris explicitly set. Override registry defaults withtransparent/0for fill-only rendering.nullinstead ofundefinedfor 'none' and correctly detect the unset state in the UI.Root cause: The
styleRegistrymerges defaults (includingline-color: #000000) with style props. When noline-colorproperty was present in the style object, the registry default bled through.