Migarate from Flowbite avatar into Shadcn avatar #135
+232
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryadhruv
reviewed
Dec 2, 2025
Comment on lines
46
to
54
| function getDisplayName(user?: SessionUser | null) { | ||
| if (user?.name && user.name.trim().length > 0) return user.name; | ||
| if (user?.email) { | ||
| const localPart = user.email.split('@')[0] ?? user.email; | ||
| return localPart || user.email; | ||
| } | ||
| return m.user_fallback(); | ||
| } | ||
Contributor
There was a problem hiding this comment.
More code - more potential issue. Idea is to keep it simple and streightforward, limited to component and no functional changes. Kindly follow the previous implementation, if otherwise you have a very strong reason to add new "lines"
aryadhruv
reviewed
Dec 2, 2025
| alt={getDisplayName(page.data.session.user)} | ||
| /> | ||
| <AvatarFallback> | ||
| {getInitials(page.data.session.user?.name ?? page.data.session.user?.email ?? null)} |
Contributor
There was a problem hiding this comment.
Please use the name only. We have bigger problems upstreams if we are not getting it tbh 👨🏻💻
aryadhruv
requested changes
Dec 2, 2025
Contributor
aryadhruv
left a comment
aryadhruv
left a comment
There was a problem hiding this comment.
Great start ! A few changes.
Idea is to keep the changes and scope of PR limited to components migration. Thanks !
aryadhruv
requested changes
Dec 2, 2025
Contributor
|
@shkelqim627 Let's merge this post #136 , ensuring that the button for dark mode and the avatar box has the same height. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the Flowbite Avatar component with the new Shadcn Avatar component across the codebase.
Let me know if anything needs adjustment!