Fix LNURL issues #371
Open
Fix LNURL issues #371
+53
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-kaufman
changed the base branch from
master
to
fix/sync-failed-coming-foreground
This comment has been minimized.
This comment has been minimized.
pwltr
approved these changes
Jan 19, 2026
Contributor
pwltr
left a comment
pwltr
left a comment
There was a problem hiding this comment.
I tested LNURL Auth on both LNMarkets and stacker.news, looks good. I'll test withdraw and channel later, can merge.
|
|
||
| do { | ||
| try await wallet.connectPeer(peer) | ||
| await MainActor.run { |
Contributor
There was a problem hiding this comment.
Don't need to call await MainActor.run here I think but can keep if you like to be explicit
pwltr
reviewed
Jan 19, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335
Fixes LNURL withdraw, auth, and channel opening