feat: add Paykit private payments#549
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dee822d5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dbdb9ef to
600cdf9
Compare
Observations from initial testing round:1. encountered "Duplicate payment" on private ln send. (After few sends between private contacts) Screen.Recording.2026-05-14.at.14.40.31.mov2. seems that sometimes the payment falls back to public(?) ("Received from..." is not appearing on the Recepient's activity list) Paykit Sender: bitkit_logs_2026-05-14_12-02-47.zip Screen.Recording.2026-05-14.at.13.58.13.mov3. As shown in the recording above, the payment button sometimes appears after a short delay. A similar delay can also be observed when tapping the contact’s pay icon. This is just an observation for now. 4. Private Paykit fallback / stale link observation I could not reproduce this reliably yet, but I hit it once on an older wallet that already had funds. Rough flow was:
Bob: bitkit_logs_2026-05-14_11-11-10.zip |
9fcd6cc to
8f54b6c
Compare
Description
This PR adds private Paykit payments for saved contacts.
It:
Linked Issues/Tasks
N/A
QA Notes
Manual Tests
regression:contact with no private-ready link → Send: public Paykit remains the fallback path when available.Automated Checks
git diff --check && git diff --cached --checkswiftformat --linton touched private Paykit/contact filesnode scripts/validate-translations.jsPrivatePaykitServiceTestspassed, 12 tests, 0 failuresScreenshot / Video
N/A