Skip to content

[arteval-bench] Replace element-wise similarity with Pearson similarity checks#132

Merged
xuafeng merged 1 commit intosys-intelligence:mainfrom
bastoica:bugfix-egwalker
Feb 25, 2026
Merged

[arteval-bench] Replace element-wise similarity with Pearson similarity checks#132
xuafeng merged 1 commit intosys-intelligence:mainfrom
bastoica:bugfix-egwalker

Conversation

@bastoica
Copy link
Collaborator

Description

This PR refactors how similarity between expected and observed measurements is performed by replacing element-wise similarity with Pearson correlation.

Changes

  • Replace ElementwiseSimilarityThresholdRequirement with ListSimilarityRequirement API call
  • Switch to 2-space indentation (this should have been a separate commit.....)

Testing

Tested on a installed copy of EgWalker.

Checklist

  • Tests pass locally
  • Code follows project style guidelines
  • Documentation updated (if needed)

@bastoica bastoica requested review from Couen and xuafeng February 18, 2026 22:12
@bastoica bastoica added the enhancement New feature or request label Feb 18, 2026
@bastoica bastoica self-assigned this Feb 18, 2026
@bastoica bastoica linked an issue Feb 18, 2026 that may be closed by this pull request
@bastoica bastoica changed the title Replace element-wise similarity with Pearson similarity checks [arteval-bench] Replace element-wise similarity with Pearson similarity checks Feb 18, 2026
@xuafeng xuafeng merged commit 4848698 into sys-intelligence:main Feb 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[arteval-bench] Improve EgWalker expected vs. actual results comparion

2 participants