Skip to content

Batch cppcheck invocation in pre-commit hook #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into from
Mar 27, 2026
+10 −10
Merged

Batch cppcheck invocation in pre-commit hook #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions scripts/pre-commit.hook
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ check_required_tools

CPPCHECK_OPTS="-I. -Iinclude -Isrc --enable=all --error-exitcode=1"
CPPCHECK_OPTS+=" $(detect_cc_std)"
CPPCHECK_OPTS+=" --force $(cppcheck_suppressions)"
CPPCHECK_OPTS+=" --max-configs=4 $(cppcheck_suppressions)"
CPPCHECK_OPTS+=" -D_GNU_SOURCE -DKBOX_UNIT_TEST"

workspace=$(git rev-parse --show-toplevel)
Expand Down Expand Up @@ -250,17 +250,17 @@ fi
# === CHECK 6: Static analysis ===
update_progress "Running static analysis"
if [ ${#C_FILES[@]} -gt 0 ]; then
cppcheck_errors=0
existing_c_files=()
for file in "${C_FILES[@]}"; do
if [ -f "$file" ]; then
if ! cppcheck $CPPCHECK_OPTS "$file" > /dev/null 2>&1; then
cppcheck_errors=$((cppcheck_errors + 1))
fi
fi
[ -f "$file" ] && existing_c_files+=("$file")
done
if [ $cppcheck_errors -gt 0 ]; then
report_result 1 "$cppcheck_errors file(s) failed static analysis"
RETURN=1
if [ ${#existing_c_files[@]} -gt 0 ]; then
if ! cppcheck $CPPCHECK_OPTS "${existing_c_files[@]}" > /dev/null 2>&1; then
report_result 1 "Static analysis errors found"
RETURN=1
else
report_result 0
fi
else
report_result 0
fi
Expand Down
Loading