tests: fix flaky_TestConnectionHandlerOpenUpdateClose#507
Merged
oleg-jukovec merged 1 commit intomasterfrom Feb 3, 2026
Merged
Conversation
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
1dd596b to
6f4180e
Compare
Collaborator
Author
|
Changes are ready. Please look this. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
6f4180e to
a0bc666
Compare
oleg-jukovec
requested changes
Dec 16, 2025
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
2 times, most recently
from
4ce2ff8 to
cdc571e
Compare
Collaborator
Author
|
The problem has not been solved yet. Most likely, the problem lies elsewhere, not in time. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
cdc571e to
44195e6
Compare
oleg-jukovec
requested changes
Jan 20, 2026
Collaborator
Author
|
Okay, I'll take a look. At the moment, the test is not flaking, but unfortunately, the time reduction is insignificant. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
44195e6 to
c5bc08d
Compare
Collaborator
Author
|
While I'm at work, I seem to have found the cause of the problems. discovered is not updated after switching to RO. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
c5bc08d to
fbdbc18
Compare
Collaborator
Author
|
I'm waiting for the main branch to be updated so that all the tests work. My local tests passed even 50,000 repetitions. Take a look, please. |
Collaborator
Author
|
We discussed it on a conference call. After all, it's about the CheckTimeout time, we decided that 100ms would be enough. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
e8283d2 to
fbdbc18
Compare
Increased the time CheckTimeout to 100 milliseconds. The previous timeout leads to too early fail in pool.Connect. Closes #502
oleg-jukovec
force-pushed
the
babyTsakhes/gh-502-flaky_TestConnectionHandlerOpenUpdateClose
branch
from
fbdbc18 to
adba830
Compare
oleg-jukovec
approved these changes
Feb 3, 2026
bigbes
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests: fix flaky_TestConnectionHandlerOpenUpdateClose
Closes #502