fix(procrastinate): track periodic tasks via job_manager.defer_periodic_job#49
Merged
Merged
Conversation
…ic_job Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Procrastinate's
PeriodicDeferrerenqueues jobs by callingapp.job_manager.defer_periodic_job(job=...)directly, bypassingtask.defer/defer_async. Our integration only wrapped the latter, so@app.periodictasks ran with zero TaskBadger visibility — no PENDING task at enqueue, no status updates from the worker (the__taskbadger_task_id__kwarg was never injected).Fix patches
app.job_manager.defer_periodic_jobper-app: looks up the task byjob.task_name, runs the same auto/manual/includes/excludes gate as the regular defer path, and usesjob.evolve(task_kwargs=...)to inject the TB id. Worker-side wrapper is unchanged.Known edge case left as follow-up: if
defer_periodic_jobreturnsNone(race — another worker already deferred the same(task, periodic_id, timestamp)), the PENDING TB task we created becomes orphaned. Only happens under multi-worker contention.🤖 Generated with Claude Code