Skip to content

fix: loosen constraints on optionally_keyed_by for msgspec #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhishekmadan30 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: loosen constraints on optionally_keyed_by for msgspec #904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/taskgraph/util/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import re
from collections.abc import Mapping
from functools import reduce
from typing import Literal, Optional, Union
from typing import Any, Literal, Optional, Union

import msgspec
import voluptuous
Expand Down Expand Up @@ -79,9 +79,11 @@ def optionally_keyed_by(*arguments, use_msgspec=False):
if use_msgspec:
# msgspec implementation - return type hints
_type = arguments[-1]
if _type is object:
return object
fields = arguments[:-1]
bykeys = [Literal[f"by-{field}"] for field in fields]
return Union[_type, dict[UnionTypes(*bykeys), dict[str, _type]]]
return Union[_type, dict[UnionTypes(*bykeys), dict[str, Any]]]
else:
# voluptuous implementation - return validator function
schema = arguments[-1]
Expand Down
Loading