Skip to content
This repository was archived by the owner on Apr 14, 2026. It is now read-only.

Refactor chats tab now scrolls to top, when tab pressed during opened (#1513)#1520

Open
Ilgz wants to merge 3 commits intomainfrom
1513-scroll-chats-top-when-tab-clicked
Open

Refactor chats tab now scrolls to top, when tab pressed during opened (#1513)#1520
Ilgz wants to merge 3 commits intomainfrom
1513-scroll-chats-top-when-tab-clicked

Conversation

@Ilgz
Copy link
Copy Markdown
Contributor

@Ilgz Ilgz commented Nov 22, 2025

Resolves #1513

Synopsis

Scrolling behavior for the Chats tab when re-selecting the tab button.

Solution

When the user taps the Chats tab button in the CustomNavigationBar, the Chats list should automatically scroll to the top.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@Ilgz Ilgz self-assigned this Nov 22, 2025
@Ilgz Ilgz added enhancement Improvement of existing features or bugfix k::UI/UX UI (user interface) and UX (user experience) changes k::refactor Refactor changes of existing code labels Nov 22, 2025
@Ilgz Ilgz added this to the 0.7.0 milestone Nov 22, 2025
@Ilgz
Copy link
Copy Markdown
Contributor Author

Ilgz commented Nov 22, 2025

FCM

Refactor chats tab now scrolls to top, when tab pressed during opened  state (#1520, #1513)

@Ilgz Ilgz force-pushed the 1513-scroll-chats-top-when-tab-clicked branch from fab5f22 to a43b24c Compare November 22, 2025 16:02
@Ilgz Ilgz requested a review from SleepySquash November 22, 2025 16:03
@Ilgz Ilgz force-pushed the 1513-scroll-chats-top-when-tab-clicked branch from a43b24c to 47fbb8e Compare November 22, 2025 16:20
Copy link
Copy Markdown
Contributor

@SleepySquash SleepySquash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ilgz, don't ignore Contribution Guide, please. And also it seems that you're in a hurry, since there's a lot of things I've noticed that can be resolved just by doing a self-review or self-checkup before sending task for a review. Please, you shouldn't hurry. Let's aim for quality. If there's anything you aren't sure about, then take an hour or two to reflect about it!

Comment thread lib/ui/page/home/tab/chats/view.dart Outdated
Comment thread lib/ui/page/home/tab/chats/view.dart Outdated
Comment thread lib/ui/page/home/tab/chats/view.dart Outdated
Comment thread lib/ui/page/home/view.dart Outdated
Comment thread CHANGELOG.md Outdated
@SleepySquash SleepySquash modified the milestones: 0.6.11, 0.7.0 Nov 24, 2025
@Ilgz Ilgz requested a review from SleepySquash November 24, 2025 15:24
@SleepySquash SleepySquash modified the milestones: 0.6.12, 0.7.0 Dec 1, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.13, 0.7.0 Dec 8, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.14, 0.7.0, 0.8.0 Dec 19, 2025
@SleepySquash SleepySquash modified the milestones: 0.7.1, 0.8.0, 0.7.2 Jan 7, 2026
@SleepySquash SleepySquash removed this from the 0.8.0 milestone Jan 21, 2026
@SleepySquash SleepySquash modified the milestones: 0.9.0, 0.8.1 Jan 21, 2026
@SleepySquash SleepySquash modified the milestones: 0.8.2, 0.9.0, 0.10.0 Feb 2, 2026
@SleepySquash SleepySquash modified the milestones: 0.9.1, 0.10.0, 0.9.2 Feb 11, 2026
@SleepySquash SleepySquash modified the milestones: 0.9.3, 0.10.0, 0.9.4 Feb 23, 2026
@SleepySquash SleepySquash modified the milestones: 0.9.5, 0.10.0, 0.9.6 Mar 9, 2026
@SleepySquash SleepySquash modified the milestones: 0.10.0, 0.11.0 Mar 26, 2026
@SleepySquash SleepySquash modified the milestones: 0.10.1, 0.11.0, 0.10.2 Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code k::UI/UX UI (user interface) and UX (user experience) changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scroll Chats tab to the top when pressing Chats button in CustomNavigationBar

2 participants