Skip to content

Debounce first ChatEvents when subscribed with version (#792)#795

Draft
SleepySquash wants to merge 4 commits intomainfrom
792-debounce-chat-events
Draft

Debounce first ChatEvents when subscribed with version (#792)#795
SleepySquash wants to merge 4 commits intomainfrom
792-debounce-chat-events

Conversation

@SleepySquash
Copy link
Copy Markdown
Contributor

@SleepySquash SleepySquash commented Jan 11, 2024

Resolves #792

Synopsis

Из-за того, что на chatEvents может идти подписка с версией, отстающей от актуальной, поэтому события налетают один за другим, то показывая звонок, то его скрывая, то показывая какие-то вещи, то их скрывая, итд.

Solution

PR добавляет ивенты в список ивентов, которые затем по дебаунсу будут обработаны.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@SleepySquash SleepySquash added enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code labels Jan 11, 2024
@SleepySquash SleepySquash self-assigned this Jan 11, 2024
@SleepySquash SleepySquash changed the title Debounce first ChatEvents when subscribed with version Debounce first ChatEvents when subscribed with version (#792) Jan 11, 2024
@SleepySquash SleepySquash added this to the 0.1.0-alpha.12 milestone Jan 12, 2024
@SleepySquash SleepySquash added the waiting::materials There is a need for additional actions/info (temporary) label Jan 12, 2024
@SleepySquash
Copy link
Copy Markdown
Contributor Author

Requires #784, as otherwise all of the debounced events are just simply ignored, as this PR is useless.

@SleepySquash SleepySquash modified the milestones: 0.4.0, 0.3.2 Jan 31, 2025
@SleepySquash SleepySquash modified the milestones: 0.3.3, 0.4.0 Mar 4, 2025
@SleepySquash SleepySquash modified the milestones: 0.4.0, 0.5.0, 0.4.1 Apr 11, 2025
@SleepySquash SleepySquash modified the milestones: 0.4.2, 0.5.0 Apr 22, 2025
@SleepySquash SleepySquash modified the milestones: 0.4.3, 0.5.0, 0.6.0 May 6, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.1, 1.0.0, 0.6.0 Jun 3, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.2, 0.6.0 Jul 1, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.3, 0.6.0 Jul 10, 2025
@SleepySquash SleepySquash modified the milestones: 0.5.4, 0.6.0 Jul 24, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.0, 0.7.0 Aug 7, 2025
@SleepySquash SleepySquash modified the milestones: 0.6.1, 0.7.0, 0.6.2 Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement of existing features or bugfix k::refactor Refactor changes of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce ChatEvents debouncing when initially subscribing to chatEvents

1 participant