Skip to content

added new Get-TeamViewerInstallationType function#96

Merged
stefanhubertus merged 1 commit intomainfrom
new_Get-TeamViewerInstalltionType_function
Feb 11, 2026
Merged

added new Get-TeamViewerInstallationType function#96
stefanhubertus merged 1 commit intomainfrom
new_Get-TeamViewerInstalltionType_function

Conversation

@radu-cristea-15
Copy link
Collaborator

@radu-cristea-15 radu-cristea-15 commented Feb 5, 2026

Added new Get-TeamViewerInstallationType function that returns the TV installation type (Exe or Msi) from locally installed TV client

@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch 2 times, most recently from 8c7e2bb to 269f65d Compare February 5, 2026 14:46
Copy link
Collaborator

@AchilleasMitos-TV AchilleasMitos-TV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description to your PR.
Also, please enrich your commit message with more details about what the new Cmdlet does.

@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch 2 times, most recently from 78d3bbc to dbd4684 Compare February 6, 2026 12:38
@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch 2 times, most recently from 7eefa38 to bc30cf3 Compare February 6, 2026 14:48
Copy link
Collaborator

@AchilleasMitos-TV AchilleasMitos-TV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the PR in its totality, however I am not an expert on the topic of the different installation modes for the TV client. I would suggest to follow @stefanhubertus 's comments and wait for his approval before moving forward with this PR.

I have run the tests locally (they all pass) and tested out that the new Cmdlet works for the 'Exe' version of the client.

There are still two files that need to be changed in order for me to consider this PR as 'Approved'. One is the Cmdlets/TeamViewerPS.psd1 which needs to bump the minor version of the module that will contain the new Cmdlet; the other is the CHANGELOG.md which describes the difference to the last published version of the module. See this PR for an example.

@stefanhubertus
Copy link
Contributor

I have reviewed the PR in its totality, however I am not an expert on the topic of the different installation modes for the TV client. I would suggest to follow @stefanhubertus 's comments and wait for his approval before moving forward with this PR.

I have run the tests locally (they all pass) and tested out that the new Cmdlet works for the 'Exe' version of the client.

There are still two files that need to be changed in order for me to consider this PR as 'Approved'. One is the Cmdlets/TeamViewerPS.psd1 which needs to bump the minor version of the module that will contain the new Cmdlet; the other is the CHANGELOG.md which describes the difference to the last published version of the module. See this PR for an example.

You are correct! The changelog.md should also then contain the changes from the recent merged pull requests - they were not in a release yet.

@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch from bc30cf3 to 1e431f3 Compare February 11, 2026 14:18
@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch from 1e431f3 to da4c654 Compare February 11, 2026 14:55
…tallation type of TeamViewer (MSI, Exe, or Unknown) and updated the CHANGELOG
@radu-cristea-15 radu-cristea-15 force-pushed the new_Get-TeamViewerInstalltionType_function branch from da4c654 to 2420580 Compare February 11, 2026 15:07
@stefanhubertus stefanhubertus merged commit 50ad316 into main Feb 11, 2026
1 check passed
@radu-cristea-15 radu-cristea-15 deleted the new_Get-TeamViewerInstalltionType_function branch February 11, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants