added new Get-TeamViewerInstallationType function#96
Conversation
8c7e2bb to
269f65d
Compare
AchilleasMitos-TV
left a comment
There was a problem hiding this comment.
Please add a description to your PR.
Also, please enrich your commit message with more details about what the new Cmdlet does.
78d3bbc to
dbd4684
Compare
7eefa38 to
bc30cf3
Compare
AchilleasMitos-TV
left a comment
There was a problem hiding this comment.
I have reviewed the PR in its totality, however I am not an expert on the topic of the different installation modes for the TV client. I would suggest to follow @stefanhubertus 's comments and wait for his approval before moving forward with this PR.
I have run the tests locally (they all pass) and tested out that the new Cmdlet works for the 'Exe' version of the client.
There are still two files that need to be changed in order for me to consider this PR as 'Approved'. One is the Cmdlets/TeamViewerPS.psd1 which needs to bump the minor version of the module that will contain the new Cmdlet; the other is the CHANGELOG.md which describes the difference to the last published version of the module. See this PR for an example.
You are correct! The changelog.md should also then contain the changes from the recent merged pull requests - they were not in a release yet. |
bc30cf3 to
1e431f3
Compare
1e431f3 to
da4c654
Compare
…tallation type of TeamViewer (MSI, Exe, or Unknown) and updated the CHANGELOG
da4c654 to
2420580
Compare
Added new Get-TeamViewerInstallationType function that returns the TV installation type (Exe or Msi) from locally installed TV client