perf: load Munsell color reference CSV once at startup#363
Merged
johannesparty merged 1 commit intomainfrom Apr 1, 2026
Merged
perf: load Munsell color reference CSV once at startup#363johannesparty merged 1 commit intomainfrom
johannesparty merged 1 commit intomainfrom
Conversation
The 8,500-row CSV was being read on every call to list_soils(). Now loaded once at module level in config.py. Also precompute the numpy array for LAB_ref and use np.argmin instead of pd.DataFrame.idxmin in lab2munsell to avoid repeated pandas overhead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
garobrik
approved these changes
Mar 25, 2026
Member
garobrik
left a comment
garobrik
left a comment
There was a problem hiding this comment.
sure! were you able to see how big a perf difference this made?
Contributor
Author
I don't think it made much performance difference, but it does feel better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a critical change, but it does make things more efficient and it isn't particularly complicated.
The 8,500-row CSV was being read on every call to list_soils(). Now loaded once at module level in config.py. Also precompute the numpy array for LAB_ref and use np.argmin instead of pd.DataFrame.idxmin in lab2munsell to avoid repeated pandas overhead.
Not really sure if want the changes in .pre-commit-config.yaml, but let's see how the automated tests go.