Poolv3 - agnostic price oracles #243
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teller-protocol-v2 into feature/agnostic-oracle
ethereumdegen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new implementation for Pools (PoolsV3) which allows for agnostic price adapters. Instead of being locked in to the UniswapPriceAdapter, any price adapter may be used as long as it is an already-deployed contract which implements the interface.
The interface allows for 1) registering pool routes and then 2) querying for price for a particular route. Price is communicated in an expanded form, Q96 format, which allows for decimals/fractions as it is expanded by 96 bits or 2^96 .