refactor(cache): use xxh64 instead of crc32 #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xHeaven
force-pushed
the
fix/view-cache-collision-resistance
branch
from
7d3cfb1 to
f6b3ea0
Compare
xHeaven
changed the title
xHeaven
changed the title
xHeaven
force-pushed
the
fix/view-cache-collision-resistance
branch
from
f6b3ea0 to
b68778a
Compare
innocenzi
changed the title
innocenzi
approved these changes
Jan 26, 2026
aidan-casey
approved these changes
Jan 26, 2026
xHeaven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1903.
Also eliminates
crc32from Tempest entirely, it provides almost no practical advantage overxxh64, while having a significantly higher collision risk.In my benchmarks with 100M iterations
xxh64was only ~7-10% slower compared tocrc32.