Skip to content

refactor(cache): use xxh64 instead of crc32 #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 2 commits into from
Jan 26, 2026
Merged

refactor(cache): use xxh64 instead of crc32 #1917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31d87ac
fix(view): use xxh64 for ViewCache key
xHeaven Jan 26, 2026
b68778a
fix(discovery): use xxh64 for DiscoveryLocation key
xHeaven Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/discovery/src/DiscoveryLocation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ final class DiscoveryLocation
public readonly string $path;

public string $key {
get => (string) crc32($this->path);
get => hash('xxh64', $this->path);
}

public function __construct(
Expand Down
2 changes: 1 addition & 1 deletion packages/view/src/ViewCache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function clear(): void

public function getCachedViewPath(string $path, Closure $compiledView): string
{
$cacheKey = (string) crc32($path);
$cacheKey = hash('xxh64', $path);

$cacheItem = $this->pool->getItem($cacheKey);

Expand Down