Skip to content

[DO NOT MERGE] Generate nexus service definitions #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spkane31 wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Generate nexus service definitions #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8bba99f
first iteration of generating
spkane31 Apr 3, 2026
c4d5172
merge conflicts
spkane31 Apr 3, 2026
7a3c4c5
getting latest changes
spkane31 Apr 3, 2026
5ad0608
broke code gen
spkane31 Apr 6, 2026
394ec17
generate code after a fix
spkane31 Apr 6, 2026
c23ae09
merge conflicts
spkane31 Apr 6, 2026
44a4399
removing
spkane31 Apr 6, 2026
f85b476
updating
spkane31 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.idea
.gobincache
.go-helpers-installed
.go-nexus-installed
/descriptor_set.pb
32 changes: 25 additions & 7 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,26 @@ update-proto-submodule:
printf $(COLOR) "Update proto-submodule..."
git -c protocol.file.allow=always submodule update --init --force --remote $(PROTO_ROOT)

##### Compile proto files for go #####
grpc: http-api-docs go-grpc copy-helpers
NEXUS_RPC_GEN_SRC ?= $(HOME)/git/github.com/nexus-rpc/nexus-rpc-gen
NEXUS_SCHEMA_ROOT := $(PROTO_ROOT)/nexus
NEXUS_OUT := workflowservice/v1/workflowservicenexus

# Only install helper when its source has changed
##### Compile proto files for go #####
grpc: http-api-docs go-grpc copy-helpers nexus-gen

nexus-gen:
printf $(COLOR) "Generate nexus service definitions..."
mkdir -p $(NEXUS_OUT)
cd $(NEXUS_SCHEMA_ROOT) && nexus-rpc-gen \
--lang go \
--package workflowservicenexus \
--out-file $(CURDIR)/$(NEXUS_OUT)/service_nexus.pb.go \
temporal-proto-models-nexusrpc.yaml

# Only install helpers when their source has changed
HELPER_FILES = $(shell find ./cmd/protoc-gen-go-helpers)
.go-helpers-installed: $(HELPER_FILES)
printf $(COLOR) "Installing protoc plugin"
printf $(COLOR) "Installing protoc-gen-go-helpers plugin"
@go install ./cmd/protoc-gen-go-helpers
@touch $@

Expand Down Expand Up @@ -104,12 +117,17 @@ gen-proto-desc:
--output-descriptor=$(PROTO_OUT)/descriptor_set.pb

##### Plugins & tools #####
grpc-install:
@printf $(COLOR) "Install/update grpc and plugins..."
@go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
grpc-install: nexus-rpc-gen-install
@printf $(COLOR) "Install/update grpc plugins..."
@go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
@go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest
@go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@latest

nexus-rpc-gen-install:
@printf $(COLOR) "Install nexus-rpc-gen from local source..."
@cd $(NEXUS_RPC_GEN_SRC)/src && pnpm run build
@cd $(NEXUS_RPC_GEN_SRC)/src/packages/nexus-rpc-gen && npm link

mockgen-install:
printf $(COLOR) "Install/update mockgen..."
go install -modfile=build/go.mod github.com/golang/mock/mockgen
Expand Down
5 changes: 2 additions & 3 deletions cmd/proxygenerator/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
module go.temporal.io/api/cmd/proxygenerator

go 1.22.0

toolchain go1.24.0
go 1.25.4

replace go.temporal.io/api => ../..

Expand All @@ -14,6 +12,7 @@ require (

require (
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1 // indirect
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84 // indirect
golang.org/x/mod v0.23.0 // indirect
golang.org/x/net v0.35.0 // indirect
golang.org/x/sync v0.11.0 // indirect
Expand Down
2 changes: 2 additions & 0 deletions cmd/proxygenerator/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1 h1:e9Rjr40Z98/clHv5Yg79Is0NtosR5LXRvdr7o/6NwbA=
github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.1/go.mod h1:tIxuGz/9mpox++sgp9fJjHO0+q1X9/UOWd798aAm22M=
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84 h1:SWHt3Coj0VvF0Km1A0wlY+IjnHKsjQLgO29io84r3wY=
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84/go.mod h1:n3UjF1bPCW8llR8tHvbxJ+27yPWrhpo8w/Yg1IOuY0Y=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
Expand Down
4 changes: 3 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
module go.temporal.io/api

go 1.21
go 1.25.4

require (
github.com/golang/mock v1.6.0
github.com/grpc-ecosystem/grpc-gateway/v2 v2.22.0
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84
github.com/nexus-rpc/sdk-go v0.6.0
github.com/stretchr/testify v1.9.0
google.golang.org/genproto/googleapis/api v0.0.0-20240827150818-7e3bb234dfed
google.golang.org/genproto/googleapis/rpc v0.0.0-20240827150818-7e3bb234dfed
Expand Down
4 changes: 4 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84 h1:SWHt3Coj0VvF0Km1A0wlY+IjnHKsjQLgO29io84r3wY=
github.com/nexus-rpc/nexus-proto-annotations v0.0.0-20260330194009-e558d6edaf84/go.mod h1:n3UjF1bPCW8llR8tHvbxJ+27yPWrhpo8w/Yg1IOuY0Y=
github.com/nexus-rpc/sdk-go v0.6.0 h1:QRgnP2zTbxEbiyWG/aXH8uSC5LV/Mg1fqb19jb4DBlo=
github.com/nexus-rpc/sdk-go v0.6.0/go.mod h1:FHdPfVQwRuJFZFTF0Y2GOAxCrbIBNrcPna9slkGKPYk=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDNXVBh4M=
Expand Down
233 changes: 233 additions & 0 deletions nexusannotations/v1/options.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/api
Open in desktop
Submodule api updated 11 files
+18 −1 Makefile
+9 −4 buf.lock
+3 −0 buf.yaml
+203 −0 cmd/protoc-gen-nexus-rpc-yaml/generator.go
+10 −0 cmd/protoc-gen-nexus-rpc-yaml/go.mod
+12 −0 cmd/protoc-gen-nexus-rpc-yaml/go.sum
+14 −0 cmd/protoc-gen-nexus-rpc-yaml/main.go
+9 −0 nexus/temporal-json-schema-models-nexusrpc.yaml
+19 −0 nexus/temporal-proto-models-nexusrpc.yaml
+29 −0 nexusannotations/v1/options.proto
+4 −1 temporal/api/workflowservice/v1/service.proto
7 changes: 4 additions & 3 deletions workflowservice/v1/service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions workflowservice/v1/workflowservicenexus/service_nexus.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading