Include queue name in sdk-otel dashboard#80
Open
danielvandenberg95 wants to merge 1 commit intotemporalio:masterfrom
Open
Include queue name in sdk-otel dashboard#80danielvandenberg95 wants to merge 1 commit intotemporalio:masterfrom
danielvandenberg95 wants to merge 1 commit intotemporalio:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
The temporal-go-sdk-otel dashboard was changed to show task_queue in both "slots available" and "slots used".
Why?
Slot metrics are useful as an indication of what part of your system needs scaling. Currently the metrics were not identifyable to a specific queue, giving no indication of what needed scaling.
Checklist
How was this tested:
This change was also made on my local copy of this dashboard.
Any docs updates needed?
Not afaik