Open
Conversation
Sushisource
commented
Apr 1, 2026
| Statement: | ||
| - Effect: Allow | ||
| Principal: | ||
| AWS: [arn:aws:iam::031568301006:role/wci-lambda-invoke] |
Member
Author
There was a problem hiding this comment.
I assume this probably needs to be replaced with something else?
There was a problem hiding this comment.
yes. @smuneebahmad do you have the correct values?
There was a problem hiding this comment.
[
arn:aws:iam::902542641901:role/wci-lambda-invoke,
arn:aws:iam::160190466495:role/wci-lambda-invoke,
arn:aws:iam::819232936619:role/wci-lambda-invoke,
arn:aws:iam::829909441867:role/wci-lambda-invoke,
arn:aws:iam::354116250941:role/wci-lambda-invoke
]
Member
Author
There was a problem hiding this comment.
All of these should be added? What's the plan for if/when these change?
Sushisource
force-pushed
the
lambda-worker
branch
from
5388834 to
c589b5f
Compare
02strich
reviewed
Apr 1, 2026
| Statement: | ||
| - Effect: Allow | ||
| Principal: | ||
| AWS: [arn:aws:iam::031568301006:role/wci-lambda-invoke] |
There was a problem hiding this comment.
yes. @smuneebahmad do you have the correct values?
02strich
approved these changes
Apr 1, 2026
yuandrew
reviewed
Apr 2, 2026
Member
Author
|
Will wait for temporalio/cli#971 to be released so README can include instructions on configuring server. |
yuandrew
approved these changes
Apr 3, 2026
Contributor
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
LGTM, feel free to merge after the CLI gets released 😀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT while waiting to re-publish the initial version of the contrib packages, they had a bad version ref by accident.