Add SerializationContext API for core payload/failure conversion paths#1996
Open
Add SerializationContext API for core payload/failure conversion paths#1996
SerializationContext API for core payload/failure conversion paths#1996Conversation
Wire serialization context through the core workflow, worker, and primary client paths so custom payload and failure converters can see which workflow or activity owns each payload. Add focused tests for the main success and failure boundaries. See tests in test-serialization-context.ts and the workflows it uses in test/src/workflows/serialization-context.ts to see the current boundaries where serialization context is implemented.
8377564 to
234615e
Compare
72d109a to
ab2bd73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
SerializationContextAPI for core payload/failure conversion paths (i.e. workflows and activities).Scope of this PR is limited to core workflow/activity boundaries (as an effort to split: #1950 into easier to review chunks).
Specifically, the boundaries implemented in this PR are:
isLocal=true)isLocal=true)isLocal=true)Note for reviewers:
The diff looks big but about half of it is the test suite at
test-serialization-context.ts. It might be easier to review this PR starting there, to see what the serialization context across these boundaries look like.Part of [[Feature Request] Serialization context for codecs and converters #1661]
How was this tested:
test-serialization-context.tsfor the boundaries implementedtest-worker-heartbeating.tsto check serialization context is correct whenactivity starttask fails (specifically when it fails duringextractActivityInfofor a failed activity heartbeat, we want to check that the serialization context is propagated through the failure correctly).