Event History Sparkle #3049
Closed
Event History Sparkle #3049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
@claude review this for bugs/mistakes |
|
Claude finished @Alex-Tideman's task —— View job Code Review Complete ✅I've reviewed this PR for bugs and mistakes. Found 2 TypeScript errors and several observations: 🐛 Critical Issues1. Type Error in
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
87
to
107
| const eventCategory = cva( | ||
| ['flex flex-1 flex-col overflow-hidden rounded-t-lg pb-2'], | ||
| { | ||
| variants: { | ||
| classification: { | ||
| Failed: 'bg-red-800', | ||
| Canceled: 'bg-orange-900/80', | ||
| TimedOut: 'bg-orange-700', | ||
| Completed: 'bg-green-700', | ||
| Terminated: 'bg-gray-300', | ||
| Scheduled: 'bg-orange-900/50', | ||
| Initiated: 'bg-orange-900/50', | ||
| Started: 'bg-orange-900/60', | ||
| Fired: 'bg-orange-900/90', | ||
| Signaled: 'bg-orange-900/50', | ||
| CancelRequested: 'bg-orange-900/70', | ||
| Unspecified: 'bg-orange-900/60', | ||
| }, | ||
| }, | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Type Error: Missing classifications in CVA variants.
The EventClassification type includes "Open", "New", and "Running" but they're not defined in the variants. This will cause a TypeScript error when these classifications are used.
Add the missing variants:
Open: 'bg-orange-900/50',
New: 'bg-orange-900/50',
Running: 'bg-orange-900/60',
|
Additional Issue Found (not in this PR's changes): While running type checking, I found an error in The |
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| get finalClassification() { | ||
| return getLastEvent(this).classification; | ||
| }, | ||
| get input() { |
Contributor
There was a problem hiding this comment.
⚠️ Property 'input' does not exist on type 'IUserMetadata | IWorkflowExecutionStartedEventAttributes | IWorkflowExecutionCompletedEventAttributes | ... 54 more ... | INexusOperationCancelRequestFailedEventAttributes'.
| get input() { | ||
| return this.initialEvent.attributes?.input; | ||
| }, | ||
| get result() { |
Contributor
There was a problem hiding this comment.
⚠️ Property 'result' does not exist on type 'IUserMetadata | IWorkflowExecutionStartedEventAttributes | IWorkflowExecutionCompletedEventAttributes | ... 54 more ... | INexusOperationCancelRequestFailedEventAttributes'.
Contributor
|
| content={link.workflowEvent.namespace} | ||
| > | ||
| <Link {href} class="whitespace-pre-line" | ||
| <Link {href} class="whitespace-pre-line !text-white" |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| $effect(() => { | ||
| if (group?.pendingActivity) { | ||
| if (group.pendingActivity.paused) { | ||
| status = translate('workflows.paused'); |
Contributor
There was a problem hiding this comment.
⚠️ 'group.pendingActivity.attempt' is possibly 'null' or 'undefined'.
| class={groupCategory({ | ||
| category: group ? group?.category : event?.category, | ||
| classification: group | ||
| ? group.finalClassification || group.classification |
Contributor
There was a problem hiding this comment.
⚠️ 'event' is possibly 'undefined'.
| $: $eventCategoryFilter = $page.url?.searchParams?.get('category') | ||
| ? ($page.url?.searchParams | ||
| $: $eventCategoryFilter = page.url?.searchParams?.get('category') |
Contributor
There was a problem hiding this comment.
⚠️ Object is possibly 'null'.
| ...(compact ? compactEventTypeOptions : allEventTypeOptions).map((o) => ({ | ||
| ...o, | ||
| label: translate(o.label), | ||
| icon: CategoryIcon[o.value], |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'I18nKey | undefined' is not assignable to parameter of type '"nexus.link" | "nexus.nexus" | "nexus.target" | "nexus.endpoint" | "nexus.nexus-endpoint" | "nexus.endpoints" | "nexus.all-endpoints" | "nexus.my-endpoints" | "nexus.back-to-endpoints" | ... 974 more ... | "workflows.children"'.
| {:else if relationshipView} | ||
| <WorkflowRelationships /> | ||
| {:else if workersView} | ||
| <WorkflowWorkers |
Contributor
There was a problem hiding this comment.
⚠️ 'workflow' is possibly 'null'.⚠️ Type 'string | undefined' is not assignable to type 'string'.
| }); | ||
| const workflow = $derived($workflowRun.workflow); | ||
| const { groups, history } = $derived( | ||
| workflowHistoryInformation( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
| return parseInt(a.activityId) - parseInt(b.activityId); | ||
| }) || [], | ||
| const { groups } = $derived( | ||
| workflowHistoryInformation( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
| const workflow = $derived($workflowRun.workflow); | ||
| const { groups } = $derived( | ||
| workflowHistoryInformation( |
Contributor
There was a problem hiding this comment.
⚠️ Argument of type 'WorkflowExecution | null' is not assignable to parameter of type 'WorkflowExecution'.
| ), | ||
| ); | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
| </div> | ||
| {/snippet} | ||
|
|
||
| {#snippet eventNamespaceLink(link: ELink)} |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.⚠️ Type 'string | null | undefined' is not assignable to type 'string'.
| content={link.workflowEvent.namespace} | ||
| > | ||
| <Link {href} class="whitespace-pre-line" | ||
| <Link {href} class="whitespace-pre-line !text-white" |
Contributor
There was a problem hiding this comment.
⚠️ 'link.workflowEvent' is possibly 'null' or 'undefined'.
| </div> | ||
| {/if} | ||
| {/snippet} | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'key' implicitly has an 'any' type.⚠️ Parameter 'value' implicitly has an 'any' type.
| </Copyable> | ||
| </div> | ||
| {/snippet} | ||
|
|
Contributor
There was a problem hiding this comment.
⚠️ Parameter 'key' implicitly has an 'any' type.⚠️ Parameter 'value' implicitly has an 'any' type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?