Add a Selenium migration module by troglodyne · Pull Request #77 · teodesian/playwright-perl

troglodyne · 2026-02-21T18:32:37Z

case #76: It occurred to me that it would be helpful to have something which can replace Selenium::Remote::Driver usage without having to rewrite a bunch of existing tests. The added code here seeks to acccomplish this.

case teodesian#76: It occurred to me that it would be helpful to have something which can replace Selenium::Remote::Driver usage without having to rewrite a bunch of existing tests. The added code here seeks to acccomplish this.

teodesian · 2026-03-04T20:17:13Z

+sub new ( $class, %opts ) {
+    _ensure_playwright();
+
+    my $browser_name = delete $opts{browser_name} // 'firefox';


seems silly to do all this assignment when we just bless underscored versions of the opt keys later

yea, kind of went off the cob here

teodesian · 2026-03-04T20:17:49Z

+                        firefox_profile pageLoadStrategy error_handler
+                        webelement_class ua proxy debug}) {
+        if (exists $opts{$ignored}) {
+            carp "Playwright::SeleniumMigrator: ignoring Selenium option '$ignored'"


Probably should print $class here

teodesian · 2026-03-04T20:38:51Z

+    return bless {
+        _driver  => $opts{_driver},
+        _element => $opts{_element},
+        _id      => $opts{_id} // _generate_id(),


Anything creating WEs should already have a PW element with a GUID that we can pass as the _id

As such we can just die rather than providing a useless guess

teodesian · 2026-03-04T20:44:40Z

+    # avoids ElementHandle disposal issues with type().
+    $eh->click();
+
+    for my $key_string (@keys) {


Seems like a lot of work when you could map the keys to their unicode counterparts, join and fill()

teodesian

Approach seems generally sound, most of the nits to pick here are QoL

teodesian · 2026-03-04T20:45:33Z

+
+sub get_element_location ($self) {
+    my $box = $self->{_element}->boundingBox();
+    return {


just return $box

troglodyne · 2026-03-05T01:56:13Z

Pushed commit with a bit of cleanup based on commentary; comrade toboritsky seemed to pick up on the PR comments mostly like I'd hoped.

Add a Selenium migration module

348670f

case teodesian#76: It occurred to me that it would be helpful to have something which can replace Selenium::Remote::Driver usage without having to rewrite a bunch of existing tests. The added code here seeks to acccomplish this.