Fix Section 8.4: unused vars and missing sorry#470
Merged
teorth merged 1 commit intoteorth:mainfrom Mar 22, 2026
Merged
Conversation
- Replace unused `f` with `_` in `Function.equiv` left_inv/right_inv - Replace direct proof of `axiom_of_choice_from_exists_function` with `sorry` — the exercise asks to derive it from `exists_function`, so the proof should be left to the reader Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fwith_inFunction.equivleft_inv/right_invto silence warningsaxiom_of_choice_from_exists_functionwithsorry— the docstring says "establish this result directly fromexists_function", so the proof should be left as an exercise for the reader (matching the pattern ofaxiom_of_choice_from_exists_set_singleton_intersectandaxiom_of_choice_from_function_injective_inv_surjective)Test plan
lake build Analysis.Section_8_4passes (thesorryproduces only a warning, not an error)🤖 Generated with Claude Code