Skip to content

Add cycle diagram shape layout#2747

Open
vegapunk9527 wants to merge 1 commit into
terrastruct:masterfrom
vegapunk9527:codex/cycle-diagram-arcs
Open

Add cycle diagram shape layout#2747
vegapunk9527 wants to merge 1 commit into
terrastruct:masterfrom
vegapunk9527:codex/cycle-diagram-arcs

Conversation

@vegapunk9527
Copy link
Copy Markdown

/claim #1578

Summary

  • Add shape: cycle as a nested diagram layout shape.
  • Position child nodes around a circle and route clockwise edges as cubic Bezier arcs trimmed at source/destination boxes.
  • Add a txtar regression fixture covering 2, 3, 4, 5, and 6 node cycles for dagre and elk outputs.

Tests

  • go test ./d2layouts/... ./d2graph/... ./d2target/...
  • TA=1 go test ./e2etests -run 'TestE2E/txtar/cycle-diagram' -v
  • go test ./e2etests -run 'TestE2E/txtar/cycle-diagram' -v
  • ./ci/test.sh ./e2etests -run TestE2E/txtar/cycle-diagram -v
  • TA=1 ./ci/test.sh ./e2etests -run TestE2E/txtar/cycle-diagram -v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant