Conversation
|
Oh this is neat! I might also suggest bumping up to the latest version to get the new helper classes listed there |
…ocessors.html, move margin: auto before margin-top in .t-subheader, set data variable, fix ad inputs and add comments in index.html
| @import 'typography'; | ||
|
|
||
| // Third-party libraries | ||
| // third-party libraries |
There was a problem hiding this comment.
Fortunately, we can now get rid of the sass-mq import here (lines 16 and 17). We import it through line 2, which links back to this file
ashley-hebler
left a comment
There was a problem hiding this comment.
This is looking great and I'm so excited to see the shared styles as a default. I introduced a bug when I didn't include the unused CSS task in the parser so I went ahead and committed that fix with f0a5111 since it was my fault in the first place. We didn't notice it before because graphics used the old location for CSS (not in the /min folder.)
Feel free to ignore this, but I noticed that the grays used in the graphics are a little light. Their contrast is being flagged in some of my accessibility testing tools. Maybe a question to take up with the rest of the team though.
Thanks for doing this!

Todos:
Changed
templates/__common__/_package.json- bump version ofqueso-ui.templates/feature/app/index.html- changed ad inputs, added comments, set variable for feature datatemplates/feature/app/templates/macros/processors.html- added CSS classes to list component, fixed ad component inputs (to allow us to process ads fetched in the ArchieML text)Removed
typography.scssandprose.html, featureindex.html,main.scssandprocessors.htmlfiles were replaced by thequeso-uiversions.To test
data-visuals-createpath/to/data-visuals-create/bin/data-visuals-create feature test-featurenpm run data:fetchnpm run serveDefault feature ArchieML text (what is fetched when you run
npm run data:fetch)