Skip to content

fix: fall back to other axis when main scroll direction is not scrollable #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
es27 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fall back to other axis when main scroll direction is not scrollable #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/SideEffect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,17 @@ export function RemoveScrollSideCar(props: IRemoveScrollEffectProps) {
let canBeScrolledInMainDirection = locationCouldBeScrolled(moveDirection, target);

if (!canBeScrolledInMainDirection) {
return true;
// If the main direction can't be scrolled, check the other axis.
// This prevents blocking vertical scroll when the initial touch delta
// is slightly more horizontal than vertical (diagonal swipe).
const otherAxis: Axis = moveDirection === 'v' ? 'h' : 'v';

if (locationCouldBeScrolled(otherAxis, target)) {
currentAxis = otherAxis;
canBeScrolledInMainDirection = true;
} else {
return true;
}
}

if (canBeScrolledInMainDirection) {
Expand Down