Open
Conversation
…(native), Desktop (JVM), Web - JS & WASM. Upgrade Gradle, Kotlin, Compose. Remove Java specific time handling and replace with kotlinx.datetime.
Owner
|
thanks for your work on the multiplatform setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there @theapache64
I've been looking at this app of yours for quite some time and I would like to implement it as a MacOS screen saver using https://github.com/zsmb13/Kotlin-macOS-ScreenSaver-Template but before I do that I wanted to update your repo to the latest versions of Compose and get it into a Kotlin Multiplatform structure.
The repo needed some refactoring to achieve this. I implemented the targets of Macos, JVM and Web.
I added kotlinx.datetime to make the time handling multiplatform and had to tweak a few things here and there.
I remove the typography and GoogleSans fonts, as far as I can tell this is only used for the text at the bottom of the app and I didn't want to implement
composeResourcesjust for that. If you feel strongly about having those fonts I'd be happy to add them back.If you have any feedback or questions, please let me know.