Allow to set node_terminus variable

[d1nuc0m]

Allow to override default value of [server]/node_terminus in puppet.conf.
Useful in case of standalone (non-Foreman) Puppet Server installs without an ENC.

[ekohl]

Test failures look related.

[ekohl]

I think we should look at $server_node_terminus and only when it's set to exec this should we include the ENC. So perhaps:

if $server_node_terminus == 'exec' {
  class { 'puppet::server::enc':
    node_terminus => $server_node_terminus,
    enc_path      => $server_external_nodes,
  }
}

Ideally we would change $server_external_nodes to Optional[Stdlib::Absolutepath] then and drop empty string handling. That could be considered a breaking change, but I think it's for the better.

I haven't look at all at the consequences of this so there's a good chance I'm missing something.

[d1nuc0m]

Thanks, as there also is classifier option I think in that case it must be written. Maybe there also are some changes to do in the without foreman tests, as it might be possible to not want the Foreman integration but use an ENC

[oworhacz-vtech]

I bumped into this when setting new environment. As a workaround until solution is merged into new version of the module. I used this ugly code for dummy node.rb:

# Workaround for https://github.com/theforeman/puppet-puppet/pull/921
    file { '/etc/puppetlabs/puppet/node.rb':
      source => 'puppet:///modules/module_name/node.rb',
      mode   => '0777',
      notify => Service['puppetserver'],
    }

and cat modules/module_name/files/node.rb

#!/bin/bash
echo "node $1 { notify { 'hello': dummy }}"

Ugly but simple and works. We use just plain puppet no foreman or whatsoever.

A proper solution would be to just use "node_terminus = plain".