Open
Conversation
Add two new events that are sent to the event hook when a service is started and when it is stopped. These two hooks provide observability during normal operations. Note that the stop event may be followed by a terminate or panic event if the service was not stopped permanently. fixes thejerf#76
Author
|
I'm missing additional tests, but wanted to put this up to see if the general direction makes sense. I wasn't 100% sure where it made the most sense to fire the events from, but from within |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new events that are sent to the event hook when a service is started and when it is stopped. These two hooks provide observability during normal operations. Note that the stop event may be followed by a terminate or panic event if the service was not stopped permanently.
fixes #76