Skip to content

Add *WhereGeoWithin methods (Mongo > 2.4)#41

Open
CaporalDead wants to merge 4 commits intothephpleague:masterfrom
Devitek:master
Open

Add *WhereGeoWithin methods (Mongo > 2.4)#41
CaporalDead wants to merge 4 commits intothephpleague:masterfrom
Devitek:master

Conversation

@CaporalDead
Copy link
Copy Markdown

This PR adds support to "$geoWithin" keyword instead of "$within" which was deprecated after Mongo 2.4.

@CaporalDead
Copy link
Copy Markdown
Author

It seems that the tests are failing because of MongoDB not returning the data in the same order as expected.

Comment thread composer.json Outdated
@@ -1,5 +1,5 @@
{
"name": "league/monga",
"name": "devitek/monga",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vendor should stay as "league"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad, I published a new version on my fork, I forget that the PR will update too. I'll fix it right now !

@CaporalDead
Copy link
Copy Markdown
Author

@bcrowe Updated ! Thx for your feedback :)

@CaporalDead
Copy link
Copy Markdown
Author

Any update guys :) ?

@CaporalDead
Copy link
Copy Markdown
Author

Up ❓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants