Skip to content

Fix caching for empty dotenv files #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ReinerBRO wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

Fix caching for empty dotenv files #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dotenv/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _get_stream(self) -> Iterator[IO[str]]:

def dict(self) -> Dict[str, Optional[str]]:
"""Return dotenv as dict"""
if self._dict:
if self._dict is not None:
return self._dict

raw_values = self.parse()
Expand Down
13 changes: 13 additions & 0 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import pytest

import dotenv
from dotenv.main import DotEnv


def test_set_key_no_file(tmp_path):
Expand Down Expand Up @@ -227,6 +228,18 @@ def test_get_key_none(dotenv_path):
mock_warning.assert_not_called()


def test_empty_dotenv_dict_is_cached(tmp_path):
dotenv_path = tmp_path / ".env"
dotenv_path.write_text("")
dotenv_obj = DotEnv(dotenv_path)

with mock.patch.object(dotenv_obj, "parse", wraps=dotenv_obj.parse) as mock_parse:
assert dotenv_obj.dict() == {}
assert dotenv_obj.dict() == {}

assert mock_parse.call_count == 1


def test_unset_with_value(dotenv_path):
logger = logging.getLogger("dotenv.main")
dotenv_path.write_text("a=b\nc=d")
Expand Down