ASoC: soc-acpi-intel-ptl-match: add ptl_cs42l43_agg_l3_cs35l56_l12_ghost_rt722#5754
ASoC: soc-acpi-intel-ptl-match: add ptl_cs42l43_agg_l3_cs35l56_l12_ghost_rt722#5754bardliao wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
bardliao
requested review from
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a new PTL SoundWire ACPI machine match intended to handle BIOSes that advertise a “ghost” RT722/ALC722 codec _ADR even when the device is not physically present, by providing an _ADR entry with zero endpoints so the machine driver skips it.
Changes:
- Added a new cs42l43 aggregated _ADR table that includes an extra “ghost” RT722/ALC722 device with no endpoints.
- Added new cs35l56 2-amp _ADR tables using
spk_1..spk_4endpoints. - Added a new PTL SoundWire link table + machine entry wiring these pieces together.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ost_rt722 Some BIOS include a ghost ALC722 codec ADR while the hardware is not physically present. That's why we need to create an acpi mach table with empty endpoint. The ghost ALC722 codec with empty endpoint will be skipped by the machine driver. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Closes:thesofproject#5721
| .adr = 0x000330025d072201ull, /* Ghost rt722 */ | ||
| .num_endpoints = 0, | ||
| .endpoints = NULL, | ||
| .name_prefix = "ghost" |
| { | ||
| .adr = 0x00033001FA424301ull, | ||
| .num_endpoints = ARRAY_SIZE(cs42l43_amp_spkagg_endpoints), | ||
| .endpoints = cs42l43_amp_spkagg_endpoints, |
There was a problem hiding this comment.
I will wait for the test result since I am not quite sure if cs42l43 amp is aggregated with cs35l56s. @charleskeepax FYI
There was a problem hiding this comment.
@charleskeepax Is there a way that we can support the same codec/amp combination but with different endpoints? To be more specific, cs42l43 with and without amp aggregated. The endpoint will be skipped by the machine driver, but the topology was selected before we check is the endpoint present.
Some BIOS include a ghost ALC722 codec ADR while the hardware is not physically present. That's why we need to create an acpi mach table with empty endpoint. The ghost ALC722 codec with empty endpoint will be skipped by the machine driver.