[stable-v2.13] audio: mic_privacy: Fix feature functionality after D3 resume#10037
Merged
lgirdwood merged 1 commit intothesofproject:stable-v2.13from May 30, 2025
Merged
Conversation
When resuming from D3 state, the microphone privacy feature wasn't properly restored, causing two critical issues: 1. The system didn't respond to privacy button inputs after D3 transitions 2. A short fade-out effect appeared in audio when privacy was enabled, causing test failures that expected complete silence This patch provides a comprehensive solution by: - Adding mic_privacy_manager_init() to resume_dais() to ensure proper re-initialization of the microphone privacy subsystem after D3 - Implementing mic_privacy_get_mic_disable_status() to correctly retrieve the current microphone disable status - Storing the mic_disable_status before entering D3 and comparing it after resume to detect changes during low power state - Enhancing mic_privacy_enable_dmic_irq() to immediately check for IRQ status after D3 transitions to catch events that occurred during suspended state - Explicitly resetting fade parameters (fade_in_out_bytes, gain parameters) to ensure immediate silence without fade artifacts when privacy is enabled - Adding proper error handling and validation to ensure the mic_priv structure is valid before access With these changes, the microphone privacy feature works correctly through power state transitions and properly mutes audio without fade artifacts when privacy is enabled after D3 resume. Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com> (cherry picked from commit aea8101) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
lgirdwood
approved these changes
May 30, 2025
tmleman
approved these changes
May 30, 2025
abonislawski
approved these changes
May 30, 2025
Member
|
@wszypelt good to merge ? |
Member
Pls ignore, just been informed your CI does not run for stable fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resuming from D3 state, the microphone privacy feature wasn't properly restored, causing two critical issues:
This patch provides a comprehensive solution by:
With these changes, the microphone privacy feature works correctly through power state transitions and properly mutes audio without fade artifacts when privacy is enabled after D3 resume.
(cherry picked from commit aea8101)