module-adapter: remove a superfluous check#10038
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Jun 9, 2025
Merged
module-adapter: remove a superfluous check#10038lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Remove a superfluous check for impossible return codes in module_adapter_sink_source_copy, making the error path clearer.
- Simplify error handling by removing the special-case suppression of
-ENOSPCand-ENODATA - Log all non-zero returns from
module_process_sink_src
Comments suppressed due to low confidence (1)
src/audio/module_adapter/module_adapter.c:994
- [nitpick] Consider adding a unit or integration test to cover the error path in
module_adapter_sink_source_copy, verifying that failures frommodule_process_sink_srcare logged and returned as expected.
comp_err(dev, "module_adapter_sink_source_copy() process failed with error: %d",
kv2019i
reviewed
Jun 2, 2025
Remove a check for an impossible condition and make code clearer. The
check became redundant after 097405872507 ("module_adapter: Don't
propagate ENOSPC and ENODATA error codes"). Presence of redundant
checks makes code confusing.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
kv2019i
approved these changes
Jun 6, 2025
lgirdwood
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a check for an impossible condition and make code clearer. The check became redundant after 097405872507 ("module_adapter: Don't propagate ENOSPC and ENODATA error codes"). Presence of redundant checks makes code confusing.