topology2: add sof-sdw-generic.tplg#10040
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Jun 9, 2025
Merged
Conversation
sof-sdw-generic.tplg will be the default topology for new SDCA audio configs. It is not likely be used since the split topologies will be used. However, the sof-sdw-generic.tplg should be present in the file system to avoid the tplg file not exist error. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds the sof-sdw-generic topology file to the production targets to prevent missing file errors for SDCA audio configurations.
- Added a new target with configuration parameters (e.g., SDW_DMIC, NUM_SDW_AMP_LINKS, etc.) for the sof-sdw-generic topology.
- Ensures the file exists in the filesystem to avoid runtime errors.
Comment on lines
+6
to
+8
| "cavs-sdw\;sof-sdw-generic\;SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | ||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" |
There was a problem hiding this comment.
[nitpick] Consider formatting the long configuration string over multiple lines or adding an inline comment to explain the parameter grouping for improved maintainability.
Suggested change
| "cavs-sdw\;sof-sdw-generic\;SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | |
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | |
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" | |
| "cavs-sdw\;sof-sdw-generic\;" | |
| # Enable DMIC and set the number of SmartAmp links | |
| "SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\" | |
| # Configure SmartAmp feedback and streams | |
| "SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\" | |
| # Configure Jack streams | |
| "SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" |
Member
There was a problem hiding this comment.
This is a good idea - now can copilot automatically do this for each file ?
Collaborator
Author
There was a problem hiding this comment.
Hmm, not sure how. :P
kv2019i
approved these changes
Jun 6, 2025
lgirdwood
approved these changes
Jun 9, 2025
Comment on lines
+6
to
+8
| "cavs-sdw\;sof-sdw-generic\;SDW_DMIC=1,NUM_SDW_AMP_LINKS=1,\ | ||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_DMIC_STREAM=Capture-SmartMic,\ | ||
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack" |
Member
There was a problem hiding this comment.
This is a good idea - now can copilot automatically do this for each file ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sof-sdw-generic.tplg will be the default topology for new SDCA audio configs. It is not likely be used since the split topologies will be used. However, the sof-sdw-generic.tplg should be present in the file system to avoid the tplg file not exist error.