sof_ri_info: add Intel PTL production key fingerprint#10061
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Jun 18, 2025
Merged
sof_ri_info: add Intel PTL production key fingerprint#10061lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Add identification for the key used in SOF-2.13 to sign sof-ptl.ri and related files. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
There was a problem hiding this comment.
Pull Request Overview
Adds identification for the key used in SOF-2.13 to sign sof-ptl.ri and related files
- Introduce
PTL_INTEL_PROD_KEYbyte fingerprint constant - Register
PTL_INTEL_PROD_KEYin the key description mapping
Comments suppressed due to low confidence (2)
tools/sof_ri_info/sof_ri_info.py:511
- [nitpick] Consider adding a brief comment above this constant to describe its origin (e.g., version range or purpose) for future maintainers.
PTL_INTEL_PROD_KEY = bytes([0x89, 0xa8, 0x6a, 0xff, 0x6b, 0x1a, 0x78, 0xae,
tools/sof_ri_info/sof_ri_info.py:653
- Add a unit test to verify that
PTL_INTEL_PROD_KEYis recognized and maps to 'PTL Intel prod key', ensuring the new key is handled correctly.
PTL_INTEL_PROD_KEY : 'PTL Intel prod key',
| 0x6c, 0xa0, 0x50, 0x65, 0x92, 0x39, 0x96, 0x34, | ||
| 0x61, 0xa4, 0xeb, 0x6b, 0x11, 0xd9, 0xbe, 0xb8]) | ||
|
|
||
| PTL_INTEL_PROD_KEY = bytes([0x89, 0xa8, 0x6a, 0xff, 0x6b, 0x1a, 0x78, 0xae, |
There was a problem hiding this comment.
[nitpick] This block is very long; you might extract the fingerprint to a separate file or use a hex string with bytes.fromhex() to improve readability.
lgirdwood
approved these changes
Jun 17, 2025
abonislawski
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add identification for the key used in SOF-2.13 to sign sof-ptl.ri and related files.