kpb: Fix wrong array size#10063
Closed
serhiy-katsyuba-intel wants to merge 1 commit intothesofproject:mainfrom
Closed
kpb: Fix wrong array size#10063serhiy-katsyuba-intel wants to merge 1 commit intothesofproject:mainfrom
serhiy-katsyuba-intel wants to merge 1 commit intothesofproject:mainfrom
Conversation
The hb_mcp[] array is initialized with 3 members (these are memory caps for rballoc()). However, the array size KPB_NO_OF_MEM_POOLS is incorrectly declared as 5. This discrepancy could potentially lead to iterating over uninitialized hb_mcp[] members. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
fkwasowi and
iganakov
as code owners
serhiy-katsyuba-intel
requested review from
abonislawski,
softwarecki and
tmleman
and removed request for
fkwasowi and
iganakov
tmleman
approved these changes
Jun 17, 2025
abonislawski
approved these changes
Jun 17, 2025
Contributor
Author
|
Surprisingly, the PR fails KPB tests. That uninitialized 4th array member is used as 0 memory capabilities flags. |
Contributor
Maybe it should be explicitly declared. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hb_mcp[] array is initialized with 3 members (these are memory caps for rballoc()). However, the array size KPB_NO_OF_MEM_POOLS is incorrectly declared as 5. This discrepancy could potentially lead to iterating over uninitialized hb_mcp[] members.