Skip to content

For tac5572 and tas2883 #10566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niranjanhyti wants to merge 3 commits into
base: main
Choose a base branch
from
+24 −0
Open

For tac5572 and tas2883 #10566

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e6f0a1
topology2: add sof-mtl-tac5572-2ch.tplg for tac5572
niranjanhyti Dec 11, 2025
3cd57b9
topology2: add sof-mtl-tas2883-2ch.tplg for tas2883
niranjanhyti Feb 19, 2026
a2ab21f
topology2: add sof-mtl-tac5672-2ch.tplg for TI's tac5672
niranjanhyti Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions tools/topology/topology2/production/tplg-targets-ace1.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,30 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-rt712-l0-4ch.bin,\
HDMI1_ID=5,HDMI2_ID=6,HDMI3_ID=7,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default"

"cavs-sdw\;sof-mtl-tac5572-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,\
Copy link
Collaborator

@bardliao bardliao Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDW_AMP_FEEDBACK_STREAM is not necessary while SDW_AMP_FEEDBACK=false.

Copy link
Collaborator

@bardliao bardliao Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I can't find 'SDW_AMP_FEEDBACK_STREAM' in the existing code. Did you define it somewhere?

NUM_DMICS=0,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,DMIC0_ID=3,DMIC1_ID=4,\
SDW_DMIC=1,SDW_DMIC_STREAM=Capture-SmartMic,\
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\
HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,EFX_DMIC0_DRC_PARAMS=dmic_default"

"cavs-sdw\;sof-mtl-tas2883-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,\
SDW_JACK=false,SDW_DMIC=1,SDW_DMIC_STREAM=SDW0-Capture-SmartMic,\
NUM_DMICS=0,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,DMIC0_ID=3,DMIC1_ID=4,\
HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,EFX_DMIC0_DRC_PARAMS=dmic_default"

"cavs-sdw\;sof-mtl-tac5672-2ch\;PLATFORM=mtl,\
NUM_SDW_AMP_LINKS=1,SDW_AMP_FEEDBACK=true,SDW_SPK_STREAM=Playback-SmartAmp,\
SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,SDW_SPK_IN_STREAM=SDW0-Capture-SmartAmp,\
Copy link
Collaborator

@bardliao bardliao Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set SDW_SPK_IN_STREAM=Capture-SmartAmp, otherwise, the topology can be used when the codec is on SDW link0. Also, please double check if SDW_AMP_FEEDBACK_STREAM is used. I can't find it in the current code.

NUM_DMICS=0,PDM1_MIC_A_ENABLE=0,PDM1_MIC_B_ENABLE=0,DMIC0_ID=3,DMIC1_ID=4,\
SDW_DMIC=1,SDW_DMIC_STREAM=Capture-SmartMic,\
SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\
HDMI1_ID=7,HDMI2_ID=8,HDMI3_ID=9,DMIC0_ENHANCED_CAPTURE=true,\
EFX_DMIC0_TDFB_PARAMS=line2_generic_pm10deg,EFX_DMIC0_DRC_PARAMS=dmic_default"

# sof_sdw creates dmic01 and dmic16k no matter 1 or 2 dmics are present.
# So, HDMI link ids are the same for -2ch and -4ch topologies.
"cavs-sdw\;sof-mtl-rt712-l0-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\
Expand Down