scripts: vscode: add support for building SOF from vscode tasks#9879
scripts: vscode: add support for building SOF from vscode tasks#9879lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
lgirdwood
requested review from
dbaluta,
kv2019i,
lbetlej,
mmaka1 and
plbossart
as code owners
scripts/vscode-task.sh
Outdated
| # Current vscode tasks have difficulty executing multiple commands. | ||
|
|
||
| # setup environment | ||
| source ~/zephyrproject/.venv/bin/activate |
There was a problem hiding this comment.
same comment as for #9878 - too many hard-coded assumptions. Let's not do this
There was a problem hiding this comment.
How about make this conditional, if test -e ~/zephyrproject/.venv/bin/activate handling the default config?
I don't really mind for vscode-task.sh -- this can make the default scase easier and non-default setups can use a symlink or something like that.
There was a problem hiding this comment.
Updated to check for environment variable then default to "getting started" directories if not found.
scripts/vscode-task.sh
Outdated
| # Current vscode tasks have difficulty executing multiple commands. | ||
|
|
||
| # setup environment | ||
| source ~/zephyrproject/.venv/bin/activate |
There was a problem hiding this comment.
How about make this conditional, if test -e ~/zephyrproject/.venv/bin/activate handling the default config?
I don't really mind for vscode-task.sh -- this can make the default scase easier and non-default setups can use a symlink or something like that.
tmleman
left a comment
tmleman
left a comment
There was a problem hiding this comment.
I have nothing against adding this script, but it seems to me its usefulness may be negligible. After all, every development environment can be different. I have two such scripts that I call from vscode as a task, one written in bash and the other in PowerShell.
Will this be an example for others?
This script allows vscode to parse the build output and ctrl-click on the warnings/errors so it is quite useful. Fwiw, if your scripts are generic then I would recommend upstreaming too. Fwiw, vscode has all the tooling for all languages/tools we use in SOF today and is cross platform (it can be our IADK UI), I think its great for increasing everyone's velocity. Its not mandatory, but if developers do use it we should make it as smooth as possible. |
lgirdwood
force-pushed
the
lrg/topic/vscode
branch
from
1931701 to
59109e6
Compare
|
Changes for V2:
|
vscode tasks can execute multiple commands easily so wrap the necessary commands to use the SOF convenience script with a small script that enables the python virtual environment. Signed-off-by: Liam Girdwood <liam.r.girdwood@intel.com>
lgirdwood
force-pushed
the
lrg/topic/vscode
branch
from
59109e6 to
c5fce6e
Compare
There was a problem hiding this comment.
Seeems like quite harmless script and if it helps building sof in vscode, then that should be good enough reason to get this merged. Then again I for one have so far installed all required python stuff in my ~/.local . So is it a correct assumption that a virtual environment is always needed?
Yes - always needed for west and Zephyr tooling. |
5 participants
vscode tasks can execute multiple commands easily so wrap the necessary commands to use the SOF convenience script with a small script that enables the python virtual environment.