audio: move more code to DRAM#9880
Merged
lgirdwood merged 6 commits intothesofproject:mainfrom Apr 2, 2025
Merged
Conversation
lyakh
requested review from
RanderWang,
abonislawski,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko and
plbossart
as code owners
Collaborator
Author
|
CI:
|
kv2019i
approved these changes
Mar 12, 2025
Collaborator
Author
@lgirdwood it depends of course on the configuration - which modules you build. E.g. https://github.com/thesofproject/sof/actions/runs/13813419824/job/38640360345?pr=9880#step:8:833 tells that the cold module has 0x74fc bytes of text and 0x4d964 bytes of data, without that it would stay in the base firmware and occupy SRAM. The largest part of that is SRC coefficients. And there's one caveat - with a purely SRAM build all coefficients would be in SRAM, but with a DRAM build coefficients are copied on demand. So it isn't a complete saving. Best case SRAM is used in pass-through, then nothing is copied IIRC (or extremely little). However, if you have several SRCs running in parallel with different conversions, then those respective tables are copied, so the saving is smaller. |
Member
Just the build time info is enough - i.e. what is the increase in DRAM usage for text/data |
Collaborator
Author
@lgirdwood right, then 0x74fc bytes text + 0x4d964 bytes read-only data |
Collaborator
Author
|
CI:
|
lgirdwood
approved these changes
Mar 13, 2025
Member
Fix several return codes, a preprocessor conditional, and simplify a function. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Clarify which methods in struct comp_ops can and which cannot be marked as __cold. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
The base firmware code is never executed on hot paths, mark it all as "cold." Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add __cold qualifiers to IPC context functions. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add __cold qualifiers and debugging tests to IPC context functions. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Add __cold qualifiers and debugging tests to non-performance critical code. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Member
|
SOFCI TEST |
Member
|
PTL results were missing, retest. |
Contributor
|
IPC response time comparison report on 24th Mar 2025 for PR 9880 The test concists of two SW configurations and two tests sequences and The SW configureations are SOF main (1ef4e60) built with |
abonislawski
approved these changes
Mar 25, 2025
Member
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
Please just retest on PTL CI with cold enabled now
Collaborator
Author
@lgirdwood would make sense, yes and best also until after DRAM debugging is merged |
lgirdwood
approved these changes
Mar 31, 2025
Collaborator
Author
|
re-test after all the merges |
Collaborator
Author
|
SOFCI TEST |
lgirdwood
approved these changes
Apr 2, 2025
Contributor
|
I just add these number here as I needed to run couple of more test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAI, host and copier code is always hard linked into the base firmware image, never as loadable modules. Move a large part of non-performance critical code to DRAM