[SKIP SOFCI-TEST] tools: plugin: Fix incorrect tilde expansion in environment variable#9932
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Mar 31, 2025
Merged
Conversation
The previous documentation incorrectly suggested setting the NOISE_SUPPRESSION_MODEL_NAME variable with a quoted tilde (~). When quoted, tilde expansion does not occur, leading to an invalid path. Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com>
SurajSonawane2415
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
lyakh
changed the title
Collaborator
Since this is a documentation-only change, no need to run on-hardware tests, I've updated the subject accordingly |
lyakh
approved these changes
Mar 28, 2025
dbaluta
approved these changes
Mar 28, 2025
kv2019i
approved these changes
Mar 28, 2025
| @@ -121,7 +121,7 @@ repository to make sure OpenVino and OpenCV are configured properly. | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
minor nit: the git commit message should have a module prefix on the summary line, e.g. "tools: plugin: Fix incorrect tilde expansion"
Contributor
Author
There was a problem hiding this comment.
Thank you for the feedback and your time. I’ll keep this in mind and follow the convention in future commits.
lgirdwood
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The current documentation suggests setting the
NOISE_SUPPRESSION_MODEL_NAME variable using a quoted tilde (~):
export NOISE_SUPPRESSION_MODEL_NAME="~/path/to/model.xml"However, when quoted, ~ is not expanded to the home directory,
causing ls -l $NOISE_SUPPRESSION_MODEL_NAME to fail with
"No such file or directory." & Getting error while testing OpenVino noise
suppression model with the SOF plugin.
Fix
The correct way to set this variable is without quotes:
export NOISE_SUPPRESSION_MODEL_NAME=~/path/to/model.xmlThis ensures the path expands correctly.
Testing
Manually tested by setting the variable and verifying with ls -l.
This PR updates the documentation accordingly.